Holograms

Share scripts you wrote for Denizen-Bukkit here!
Post Reply
Berufeng
New
New
Posts: 18
Joined: January 29th, 2020, 4:40 pm

Holograms

Post by Berufeng » January 29th, 2020, 4:46 pm

This is a user-friendly command I created so server developers can place floating text and characters in the game world. The command is fully documented with help functions. Suggestions and constructive criticism welcome. Give it a try!

https://one.denizenscript.com/haste/64695

User avatar
mcmonkey
Site Admin
Site Admin
Posts: 292
Joined: August 5th, 2016, 7:27 pm
Location: Los Angeles, California, USA
Contact:

Re: Holograms

Post by mcmonkey » January 29th, 2020, 10:56 pm

- You left debug enabled on "HologramSymbolProcedure"
- You have logic like - choose <[selectarg]>: - case null: - default: which is a bit silly... use an if, or an if/else pair, as relevant.
- You have a lot of instances of as_list, which should almost all be removed.
- You have if commands like - if <[tp2].is[==].to[null]||true>: ... this should naturally be - if <[tp2]> == null: and similar for other instances
- You have a lot of fallbacks on tags that shouldn't theoretically ever be able to error. Those fallbacks should be removed. Refer also to https://guide.denizenscript.com/guides/ ... -fallbacks
Denizen lead developer. On Discord as mcmonkey#6666.

Berufeng
New
New
Posts: 18
Joined: January 29th, 2020, 4:40 pm

Re: Holograms

Post by Berufeng » February 2nd, 2020, 10:43 am

Monkey:

Thanks for the feedback! Almost everything you listed can be attributed to the fact that I originally wrote this at least two years ago and did a cursory retrofit to make it work in the newest version of Denizen. The rest can be attributed to the fact that I was still very new to Denizen back then and didn’t catch my silly logic when I revisited the script recently.

That said, your review is much appreciated and will come in very handy as a guide to fixing my mistakes! Thanks again.

Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests