Some Problems with 1.15

Discuss any issues with Denizen-Bukkit scripts or functionality you may have while using it.
Post Reply
n0nnie
New
New
Posts: 29
Joined: January 10th, 2018, 3:19 am
Location: München - Germany
Contact:

Some Problems with 1.15

Post by n0nnie » December 17th, 2019, 2:19 am

Thank you for updating to 1.15 so fast. It took me 6 hours after release to update to 1.15 =)

But:
Some issues are there:

First is on startup with newest Devbuild:
Spoiler!
[10:53:50] [Server thread/ERROR]: Error occurred while enabling Denizen v1.1.2-SNAPSHOT (build 4471-DEV) (Is it up to date?)
java.lang.NullPointerException: null
at java.util.ArrayList.addAll(ArrayList.java:577) ~[?:1.8.0_101]
at com.denizenscript.denizencore.scripts.queues.ScriptQueue.addEntries(ScriptQueue.java:695) ~[?:?]
at com.denizenscript.denizencore.events.ScriptEvent.run(ScriptEvent.java:435) ~[?:?]
at com.denizenscript.denizen.events.core.ServerPrestartScriptEvent.specialHackRunEvent(ServerPrestartScriptEvent.java:52) ~[?:?]
at com.denizenscript.denizen.Denizen.onEnable(Denizen.java:420) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[spigot.jar:git-Spigot-3b314f5-e631456]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:352) [spigot.jar:git-Spigot-3b314f5-e631456]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:417) [spigot.jar:git-Spigot-3b314f5-e631456]
at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugin(CraftServer.java:462) [spigot.jar:git-Spigot-3b314f5-e631456]
at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugins(CraftServer.java:376) [spigot.jar:git-Spigot-3b314f5-e631456]
at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:456) [spigot.jar:git-Spigot-3b314f5-e631456]
at net.minecraft.server.v1_15_R1.DedicatedServer.init(DedicatedServer.java:266) [spigot.jar:git-Spigot-3b314f5-e631456]
at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:783) [spigot.jar:git-Spigot-3b314f5-e631456]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_101]
Next Problem is:
wait command stops script. It is almost like stop command or something. Debug says that it will wait and nothing happens after this:
Spoiler!
[07:26:59] [Server thread/INFO]: [0;35;1m+- [0;35;1mQueue 'INVSEE_COMMAND_[0;33;22mParagraph[0;37;22mPromised[0;33;22mPair[0;35;1m' Executing: [0;37;1m[0;30;1m(line 179)[0;37;1m WAIT[0;35;1m ---------+ [m
[07:26:59] [Server thread/INFO]: [0;33;1m+> [0;30;1mExecuting '[0;33;1mWAIT[0;30;1m': [0;30;1mqueue='[0;33;[email protected]_COMMAND_ParagraphPromisedPair[0;30;1m' [0;30;1mdelay='[0;33;[email protected] [0;32;1m(3s)[0;30;1m' [m
[07:26:59] [Server thread/INFO]: [0;35;1m [0;37;1mForcing queue INVSEE_COMMAND_ParagraphPromisedPair into a timed queue... [m
[07:26:59] [Server thread/INFO]: [0;35;1m [0;37;1m[0;33;22mCompleting queue 'INVSEE_COMMAND_[0;33;22mParagraph[0;37;22mPromised[0;33;22mPair[0;33;22m' in 15ms. [m
[07:26:59] [Server thread/INFO]: [0;35;1m [0;37;1m[0;33;22mStarting TimedQueue 'INVSEE_COMMAND_[0;33;22mParagraph[0;37;22mPromised[0;33;22mPair[0;33;22m' with player 'n0nnie'... [m
Next Problem is:
Events on server start, on server prestart and on system time 05:00: do not fire. This script here does nothing because of the told problems:
Spoiler!
daily_autorestart:
type: world
debug: false
events:
on system time 05:00:
- announce "<gold>Server restart in ten minutes!"
- wait 5m
- announce "<gold>Server restart in five minutes!"
- wait 2m
- announce "<gold>Server restart in three minutes!"
- wait 1m
- announce "<gold>Server restart in two minutes!"
- wait 1m
- announce "<gold>Server restart in one minute!"
- wait 30s
- announce "<gold>Server restart in thirty seconds!"
- wait 30s
- adjust server restart
on restart command:
- if <player.is_op>||<context.server>:
- narrate "Server restart"
- adjust server restart
Spigot is up to date I just did newest builds and Denizen Dev Build is 4471 (11 hours ago). Maybe I am doing something wrong, or missed a change in these points?

User avatar
mcmonkey
Site Admin
Site Admin
Posts: 289
Joined: August 5th, 2016, 7:27 pm
Location: Los Angeles, California, USA
Contact:

Re: Some Problems with 1.15

Post by mcmonkey » December 17th, 2019, 10:04 am

That first error is a clearly broken server prestart event. That is your script being broken. The other issues likely stem from that first issue.
Denizen lead developer. On Discord as mcmonkey#6666.

n0nnie
New
New
Posts: 29
Joined: January 10th, 2018, 3:19 am
Location: München - Germany
Contact:

Re: Some Problems with 1.15

Post by n0nnie » December 17th, 2019, 10:00 pm

I literally had ONE prestart event in all of my scripts. This worked till 1.15 and I assumed everything is fine on my side xD

Thank you for pointing this out, it is now fixed and everythings works again =)

n0nnie
New
New
Posts: 29
Joined: January 10th, 2018, 3:19 am
Location: München - Germany
Contact:

Re: Some Problems with 1.15

Post by n0nnie » December 22nd, 2019, 9:39 am

A new strange thing happend:

I started to play with villagers and curing them. But curing them did not have the effect I wanted (lower prices). So I looked into it further. On Singleplayer it functions as intended, prices are lower if you cure villager from being a zombi. On my server this does not happen. So I thought it is spigot. I updatet, error consists. I disabled my 8 plugins and the error was gone.

I reenabeld all my plugins and error was there again. So I disabled Denizen and Depenizen and dDiscordbot. Error is gone, prices are lower. I enabled all Denizenrelated stuff again, but without my scripts. Prices are shown as not altered on the cured villager. So I tested with the cured villager and sold him 24 paper. He took all of it. After closing the tradegui I gained back 6 paper (because the cured one sells one emerald for 18 instead of 24 paper)

So Prices are low but not shown as lower if Denizen is enabled

n0nnie
New
New
Posts: 29
Joined: January 10th, 2018, 3:19 am
Location: München - Germany
Contact:

Re: Some Problems with 1.15

Post by n0nnie » January 15th, 2020, 11:36 am

"Error" still is there. I update almost every day both spitgot and Denizen. I am using Devbuilds.

As I am writing here, I have build 4547 of Denizen developmental.

I am running version 1.15.1 of Minecraft

User avatar
mcmonkey
Site Admin
Site Admin
Posts: 289
Joined: August 5th, 2016, 7:27 pm
Location: Los Angeles, California, USA
Contact:

Re: Some Problems with 1.15

Post by mcmonkey » January 15th, 2020, 5:01 pm

That was the absolute weirdest issue.

I tracked it down, the original cause is some legacy item script related code, which accidentally caused a bit of data in villager trade packets to be lost (it was trying to hide item-script-lore from the packets, which is a system we haven't used in a few years now anyway). I fixed it, by way of just removing the relevant handlers. Fix is in DEV-4548+
Denizen lead developer. On Discord as mcmonkey#6666.

n0nnie
New
New
Posts: 29
Joined: January 10th, 2018, 3:19 am
Location: München - Germany
Contact:

Re: Some Problems with 1.15

Post by n0nnie » January 16th, 2020, 3:38 am

IT WORKS! THANK YOU SO MUCH =)

Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests